Keep the 2TB Gen 3 drive and move forward with that. You’re already getting a big capacity upgrade, and flight sim won’t be bottlenecked by PCIe 3 speeds.
If you ever rebuild your system or upgrade your boot drive down the line, then you can look at a high speed 4TB Gen 4 SSD for everything.