Potential improvements for sky colors

[Buggsy 2]

Forgive my silliness, but every time I boot up MSFS I got "could not find the coefficients pattern, no changes were made". Any ideas? Latest dll, in correct steam folder.

[Drunq 98]

1 minute ago, Buggsy said:

Forgive my silliness, but every time I boot up MSFS I got "could not find the coefficients pattern, no changes were made". Any ideas? Latest dll, in correct steam folder.

This means that you somehow have a different .exe. Have you modified the executable in some way? 

[Alvega 2,125]

53 minutes ago, Drunq said:

This means that you somehow have a different .exe. Have you modified the executable in some way? 

Can't it be the decimal separator thing? Some countries use a comma instead of a dot, not sure if your files also work if he needs to use a comma instead of a dot.

Edit: but I see his location is US, so i doubt it's that.

Edited October 18, 2023 by Alvega

[turbomax 3,305]

35 minutes ago, Alvega said:

but I see his location is US, so i doubt it's that.

you can also change the decimal separator character in the windows country/currency/time format. if that doesn't work, then yes, the user has to move to USA and change the color coeficients there.

[Buggsy 2]

I had previously modified the .exe using one of the other methods for changing the coefficients, but I did that prior to the SU13 release (while I ran SU13 beta), which maybe in retrospect didnt actually "reset" the .exe...or the alternative explanation is my use of ReShade. Oh well

[Drunq 98]

34 minutes ago, Alvega said:

Can't it be the decimal separator thing? Some countries use a comma instead of a dot, not sure if your files also work if he needs to use a comma instead of a dot.

Edit: but I see his location is US, so i doubt it's that.

No, executables are stored in binary, so values are not represented with a comma or dot, just one's and zero's. Everyone should have the same executable, I think he must've applied the hex edit to the exe.

[Drunq 98]

4 minutes ago, Buggsy said:

I had previously modified the .exe using one of the other methods for changing the coefficients, but I did that prior to the SU13 release (while I ran SU13 beta), which maybe in retrospect didnt actually "reset" the .exe...or the alternative explanation is my use of ReShade. Oh well

Weird, it should have overwritten the exe.

[Alvega 2,125]

2 minutes ago, turbomax said:

you can also change the decimal separator character in the windows country/currency/time format. if that doesn't work, then yes, the user has to move to USA and change the color coeficients there.

Lol, I know he can change it in Windows, what I meant was if he is in the US it's likely he is using the dot.

[turbomax 3,305]

17 minutes ago, Drunq said:

executables are stored in binary, so values are not represented with a comma or dot, just one's and zero's.

what? the 3 values imported from the .ini files are all decimals,

RED = 0.00508
GREEN = 0.00318
BLUE = 0.0

so it should matter if windows handles them correctly, unless your code has a special character interpreter for decimal characters, which I doubt.

[Drunq 98]

18 minutes ago, turbomax said:

what? the 3 values imported from the .ini files are all decimals,

RED = 0.00508
GREEN = 0.00318
BLUE = 0.0

so it should matter if windows handles them correctly, unless your code has a special character interpreter for decimal characters, which I doubt.

No, I meant the original coefficients from the executable (exe) file. Decimals in code or configuration are always expressed with a dot, unless the developer has explicitly added support. 

[turbomax 3,305]

if the user previously has overwritten the original .exe file with any new color coeficients, then I assume your hack won't find them and that might result in the users error message, in other words: your hack works only on an un-modified original .exe, just like the Hex-editor approach. that's why I always keep a separate copy of the original flightsimulator.exe so I can always start the Drunq hack from scratch, what the "hack" 🤣

Edited October 18, 2023 by turbomax

[turbomax 3,305]

1 hour ago, Buggsy said:

I had previously modified the .exe using one of the other methods for changing the coefficients, but I did that prior to the SU13 release (while I ran SU13 beta

exactly what I did, but I think the final SU13 exe did not change after the beta, i.e. it is the same as the beta version. that would explain why you still have the modified .exe and now can not modify it again, because all hacks (hex editor file modifier or Drunq's in memory approach) work by searching the .exe for the original color coefficents. if they don't find them, you are out of luck. you'll need an unmodified original version of SU13's flightsimulator.exe. not sure if leaving the beta might overwrite your hacked .exe version again with an original un-colored SU13 .exe and that would allow another attempt at Drunq's approach.

at least that's the world according to Garp.

Edited October 18, 2023 by turbomax

[Alvega 2,125]

16 minutes ago, turbomax said:

exactly what I did, but I think the final SU13 exe did not change after the beta, i.e. it is the same as the beta version. that would explain why you still have the modified .exe and now can not modify it again, because all hacks (hex editor file modifier or Drunq's in memory approach) work by searching the .exe for the original color coefficents. if they don't find them, you are out of luck. you'll need an unmodified original version of SU13's flightsimulator.exe. not sure if leaving the beta might overwrite your hacked .exe version again with an original un-colored SU13 .exe and that would allow another attempt at Drunq's approach.

at least that's the world according to Garp.

I guess he may solve the issue by editing the exe with HxD and replacing the values with the original ones if he doesn't have a backup of the exe. Then Drunq's hack would find the values.

[Mike_CFII_MEL 797]

Hi,

Made the edits some time ago and they look great. I tried to go from DX12 to DX11, wanted to try a few things to maybe smooth out performance. When I check on the DX12 arrow it won't change. Think this could be related to the edit? I wouldn't think so, but you never know.

any ideas?

Thanks

[turbomax 3,305]

49 minutes ago, Alvega said:

editing the exe with HxD and replacing the values with the original ones

how will he find the memory locations?